Skip to content

handle new error behaviour in python 3.7 - fixes #40#44

Merged
julie-sullivan merged 1 commit intointermine:devfrom
yochannah:fix-40-template-error
Jun 28, 2019
Merged

handle new error behaviour in python 3.7 - fixes #40#44
julie-sullivan merged 1 commit intointermine:devfrom
yochannah:fix-40-template-error

Conversation

@yochannah
Copy link
Copy Markdown
Member

small fix for #40. This fixes it on my machine when running 3.7.

Travis is failing on environmental setup issues (Java) and I can't figure out why. This is four lines different from the intermine dev branch!

@julie-sullivan could you help by any chance? It would be nice to have this available for the GCC workshop next week.

@julie-sullivan
Copy link
Copy Markdown
Member

Does this include changes in #38?

@yochannah
Copy link
Copy Markdown
Member Author

No - should it?

@yochannah
Copy link
Copy Markdown
Member Author

okay, it appears that the same commit passed on the PR pipeline even though it failed on my personal branch. Let's pretend my branch never failed as it's clearly some sort of environment issue. 😭

@julie-sullivan
Copy link
Copy Markdown
Member

No - should it?

  1. Take a look. Maybe? There are some small changes but then a big one in ListManager that needs testing.

  2. Do you need me to test? What should I be looking for?

  3. There are instructions on how to publish the python client in the google drive under "python client".

@yochannah
Copy link
Copy Markdown
Member Author

Hmmmm.

No - should it?

1. Take a look. Maybe? There are some small changes but then a big one in ListManager that needs testing.

The big one in ListManager is really hard to review as it's a mix of whitespace and actual code changes. It would be nice to leave it until later.

2. Do you need me to test? What should I be looking for?

This only affects get_template -(I hope). You can see the full error in #40. To reproduce, run this:

from intermine.webservice import Service
service = Service("www.flymine.org/flymine/service")
template = service.get_template('Gene_Pathway')
print("flymine", template.views)

If it doesn't error under python 3.7 (and no other errors crop up - I'd suggest running both test suites) then we should be good to go!

To test different python versions, I did this to create a new environment (assuming you have anaconda installed):

conda create -n template_bug35 python=3.5
conda activate template_bug35
conda install -c bioconda intermine

replace with 3.7 in the above code to test in python 3.7. You'll need to install intermine (the python package) each time you activate a new environment

3. There are instructions on how to publish the python client in the google drive under "python client".

cool - let me know if you think it's ready / once this is merged! :)

@julie-sullivan
Copy link
Copy Markdown
Member

Tested! Works great! Ready to publish.

@julie-sullivan julie-sullivan merged commit ae5b057 into intermine:dev Jun 28, 2019
@heralden heralden mentioned this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants